K2-287: add monitoring-advisor skill#34
Merged
andyliucoder merged 3 commits intomainfrom Apr 13, 2026
Merged
Conversation
Port interactive coverage agent flow to a Claude skill using public MCP tools. Includes warehouse discovery, use-case analysis, coverage gap detection, and monitor creation with cross-references to monitor-creation skill for parameter docs. Also makes aggregate_time_field optional in metric monitor reference. Co-Authored-By: Claude Opus 4.6 <[email protected]>
mdediana
reviewed
Apr 10, 2026
Address PR feedback: remove duplicated monitor type table, reference file listing, confirmation/presentation steps. Instead delegate to the monitor-creation skill for the full creation workflow. Keep only coverage-specific guidance (use-case tag asset_selection, description guidelines, audience pre-fetching). Co-Authored-By: Claude Opus 4.6 <[email protected]>
elor-arieli
approved these changes
Apr 12, 2026
Contributor
elor-arieli
left a comment
elor-arieli
left a comment
There was a problem hiding this comment.
LGTM - just thinking maybe we should add the AO monitors as well
| | `createMetricMonitorMac` | Generate metric monitor YAML (dry-run) | | ||
| | `createValidationMonitorMac` | Generate validation monitor YAML (dry-run) | | ||
| | `createCustomSqlMonitorMac` | Generate custom SQL monitor YAML (dry-run) | | ||
| | `createComparisonMonitorMac` | Generate comparison monitor YAML (dry-run) | |
Contributor
There was a problem hiding this comment.
Do you want to also add the AO monitor creation tools and skills?
Collaborator
Author
There was a problem hiding this comment.
I'll add in a separate task
…code The skill was only symlinked for claude-code. Add symlinks for all other plugins to match the unified structure. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
monitoring-advisorskill that ports the interactive coverage agent flow to a Claude skill using public MCP toolsmonitor-creationskill for the actual monitor creation workflow (DRY); keeps only coverage-specific guidance (use-case tag asset_selection, description guidelines)aggregate_time_fieldoptional in metric monitor reference — supports whole-table scans for tables without timestamp columnsCloses K2-287